Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oracle_weblogic] Add Integration Package with Managed Server Logs Data Stream #3067

Merged
merged 18 commits into from
May 23, 2022
Merged

[oracle_weblogic] Add Integration Package with Managed Server Logs Data Stream #3067

merged 18 commits into from
May 23, 2022

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Apr 11, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

  • Generated the skeleton of Oracle WebLogic integration package.
  • Added 1 data stream (Managed Server Logs).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/oracle_weblogic directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

oracle_weblogic Managed Server Dashboard

@kush-elastic kush-elastic requested a review from a team as a code owner April 11, 2022 19:27
@elasticmachine
Copy link

elasticmachine commented Apr 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-20T12:05:07.997+0000

  • Duration: 19 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic kush-elastic mentioned this pull request Apr 11, 2022
Merged
4 tasks
This was referenced Apr 11, 2022
Merged
Merged
@masci masci added the Integration:oracle_weblogic Oracle WebLogic label Apr 13, 2022
@kush-elastic kush-elastic mentioned this pull request Apr 19, 2022
Merged
4 tasks
This was referenced Apr 25, 2022
Merged
Closed
@elasticmachine
Copy link

elasticmachine commented Apr 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.788
Classes 100.0% (2/2) 💚 3.788
Methods 100.0% (18/18) 💚 12.069
Lines 100.0% (111/111) 💚 10.38
Conditionals 100.0% (0/0) 💚

agithomas
agithomas reviewed May 2, 2022
View reviewed changes
packages/oracle_weblogic/data_stream/managed_server/elasticsearch/ingest_pipeline/default.yml Show resolved Hide resolved
packages/oracle_weblogic/data_stream/managed_server/elasticsearch/ingest_pipeline/default.yml Outdated
@@ -0,0 +1,75 @@
---
description: Pipeline for processing Weblogic logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct as Pipeline for processing WebLogic managed server logs

packages/oracle_weblogic/data_stream/managed_server/manifest.yml Outdated
required: true
show_user: true
default:
- /tmp/service_logs/managed-logs/ms-1.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the default path location

@kush-elastic kush-elastic added enhancement New feature or request New Integration Team:Service-Integrations Label for the Service Integrations team labels May 3, 2022
@kush-elastic kush-elastic mentioned this pull request May 5, 2022
Closed
4 tasks
agithomas
agithomas reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@kush-elastic kush-elastic requested a review from a team as a code owner May 18, 2022 20:46
@kush-elastic kush-elastic force-pushed the package_oracle_weblogic_managed_server branch from 61873bb to c54d599 Compare May 18, 2022 20:54
@matschaffer matschaffer removed the request for review from a team May 19, 2022 01:29
@kush-elastic kush-elastic requested review from yug-rajani and removed request for yug-rajani May 19, 2022 04:25
@kush-elastic
Copy link
Collaborator Author

/test

@ari-aviran ari-aviran removed the request for review from a team May 19, 2022 07:26
yug-rajani
yug-rajani reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me, I checked the logs for the failure.

Error: error running package system tests: could not complete test run: could not setup service: removing service logs failed: removing resource failed (path: /var/lib/jenkins/workspace/est-manager_integrations_PR-3067/.elastic-package/tmp/service_logs/adminserver): unlinkat /var/lib/jenkins/workspace/est-manager_integrations_PR-3067/.elastic-package/tmp/service_logs/adminserver/domain1.log: permission denied

Looks like you'll need to fix something with the permissions there.

packages/oracle_weblogic/changelog.yml Outdated Show resolved Hide resolved
@ph ph removed the request for review from a team May 19, 2022 17:50
yug-rajani
yug-rajani approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits in comments to adjust, LGTM!

...ges/oracle_weblogic/_dev/deploy/docker/oracle_weblogic/container-scripts/startAdminServer.sh Outdated Show resolved Hide resolved
...s/oracle_weblogic/_dev/deploy/docker/oracle_weblogic/container-scripts/startManagedServer.sh Outdated Show resolved Hide resolved
kush-elastic and others added 2 commits May 20, 2022 17:34
@kush-elastic @yug-rajani
Update packages/oracle_weblogic/_dev/deploy/docker/oracle_weblogic/co…
ccd59ce 
…ntainer-scripts/startAdminServer.sh

Co-authored-by: Yug Rajani <96041884+yug-elastic@users.noreply.github.com>
@kush-elastic @yug-rajani
Update packages/oracle_weblogic/_dev/deploy/docker/oracle_weblogic/co…
1860e7e 
…ntainer-scripts/startManagedServer.sh

Co-authored-by: Yug Rajani <96041884+yug-elastic@users.noreply.github.com>
@yug-rajani yug-rajani requested a review from agithomas May 20, 2022 12:27
agithomas
agithomas approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kush-elastic kush-elastic merged commit 2c28f62 into elastic:main May 23, 2022
@yug-rajani yug-rajani linked an issue Jun 7, 2022 that may be closed by this pull request
Oracle Weblogic Integration #2823
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yug-rajani yug-rajani yug-rajani approved these changes

@agithomas agithomas agithomas approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees
No one assigned
Labels
enhancement New feature or request Integration:oracle_weblogic Oracle WebLogic New Integration Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oracle Weblogic Integration
5 participants
@kush-elastic @elasticmachine @yug-rajani @agithomas @masci