Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oracle_weblogic] Add Integration Package with Deployed Application Data Stream #3121

Merged
merged 14 commits into from
Jun 7, 2022
Merged

[oracle_weblogic] Add Integration Package with Deployed Application Data Stream #3121

merged 14 commits into from
Jun 7, 2022

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Apr 19, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

  • Generated the skeleton of Oracle WebLogic integration package.
  • Added 1 data stream (Deployed Application).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/oracle_weblogic directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

image

@kush-elastic kush-elastic requested a review from a team as a code owner April 19, 2022 13:14
@kush-elastic kush-elastic self-assigned this Apr 19, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 19, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-07T09:51:26.772+0000

  • Duration: 25 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic kush-elastic marked this pull request as draft April 19, 2022 13:29
@kush-elastic kush-elastic mentioned this pull request Apr 20, 2022
Merged
4 tasks
This was referenced Apr 25, 2022
Merged
Merged
Merged
Closed
Merged
@kush-elastic
Copy link
Collaborator Author

/test

@elasticmachine
Copy link

elasticmachine commented May 2, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.497
Classes 100.0% (4/4) 💚 3.497
Methods 100.0% (44/44) 💚 10.616
Lines 100.0% (239/239) 💚 9.209
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic added enhancement New feature or request New Integration Team:Service-Integrations Label for the Service Integrations team labels May 3, 2022
@kush-elastic kush-elastic force-pushed the package_oracle_weblogic_deployed_application branch from 1d20332 to 07151e7 Compare May 3, 2022 09:35
@kush-elastic kush-elastic mentioned this pull request May 5, 2022
Closed
4 tasks
@kush-elastic
Copy link
Collaborator Author

/test

2 similar comments
@kush-elastic
Copy link
Collaborator Author

/test

@kush-elastic
Copy link
Collaborator Author

/test

@kush-elastic
Copy link
Collaborator Author

/test

1 similar comment
@kush-elastic
Copy link
Collaborator Author

/test

yug-rajani
yug-rajani suggested changes May 31, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes

...s/oracle_weblogic/data_stream/deployed_application/elasticsearch/ingest_pipeline/default.yml Outdated
field: oracle_weblogic.deployed_application.deployment.state
value: Shutdown
ignore_empty_value: true
if: ctx.oracle_weblogic.deployed_application.deployment.state_value == 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a painless script with a HashMap seems to be a better option here.

...s/oracle_weblogic/data_stream/deployed_application/elasticsearch/ingest_pipeline/default.yml Outdated
ignore_empty_value: true
if: ctx.oracle_weblogic.deployed_application.deployment.state_value == 2
ignore_failure: true
- remove:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move remove to the end

packages/oracle_weblogic/data_stream/deployed_application/fields/fields.yml Show resolved Hide resolved
yug-rajani
yug-rajani approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic
Merge branch 'main' of https://github.com/elastic/integrations into p…
826a5f9 
…ackage_oracle_weblogic_deployed_application

Conflicts:
	packages/oracle_weblogic/_dev/build/docs/README.md
	packages/oracle_weblogic/changelog.yml
	packages/oracle_weblogic/docs/README.md
	packages/oracle_weblogic/manifest.yml
@kush-elastic kush-elastic marked this pull request as ready for review June 6, 2022 07:21
@kush-elastic kush-elastic requested a review from a team as a code owner June 6, 2022 07:21
@yug-rajani yug-rajani linked an issue Jun 7, 2022 that may be closed by this pull request
Oracle Weblogic Integration #2823
Closed
8 tasks
agithomas
agithomas reviewed Jun 7, 2022
View reviewed changes
packages/oracle_weblogic/manifest.yml
@@ -96,7 +98,7 @@ policy_templates:
- http://localhost:8004
description: "Hosts for Oracle WebLogic metrics (example: http://localhost:8004)."
- type: logfile
title: Collect Oracle WebLogic logs.
title: Collect Oracle WebLogic logs
description: Collecting Oracle WebLogic logs of Admin Server, Managed Server, Domain and Access logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description to cover all information of all the metrics that are fetched ( not just logs)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, made the changes (quick reference)

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 7, 2022 •
edited
Loading

💚 CLA has been signed

@kush-elastic kush-elastic force-pushed the package_oracle_weblogic_deployed_application branch from c85e892 to 251813d Compare June 7, 2022 09:51
agithomas
agithomas approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kush-elastic kush-elastic merged commit 2fd3342 into elastic:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yug-rajani yug-rajani yug-rajani approved these changes

@agithomas agithomas agithomas approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@kush-elastic kush-elastic

Labels
enhancement New feature or request Integration:oracle_weblogic New Integration Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oracle Weblogic Integration
4 participants
@kush-elastic @elasticmachine @yug-rajani @agithomas