Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oracle_weblogic] Add Integration Package with Domain Logs Data Stream #3069

Merged
merged 13 commits into from
May 27, 2022
Merged

[oracle_weblogic] Add Integration Package with Domain Logs Data Stream #3069

merged 13 commits into from
May 27, 2022

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Apr 11, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

  • Generated the skeleton of Oracle WebLogic integration package.
  • Added 1 data stream (Domain Logs).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/oracle_weblogic directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

oracle_weblogic Domain Dashboard

@kush-elastic kush-elastic requested a review from a team as a code owner April 11, 2022 20:52
This was referenced Apr 11, 2022
Merged
Merged
Merged
@elasticmachine
Copy link

elasticmachine commented Apr 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-27T07:02:36.655+0000

  • Duration: 21 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@masci masci added the Integration:oracle_weblogic Oracle WebLogic label Apr 13, 2022
@kush-elastic kush-elastic mentioned this pull request Apr 19, 2022
Merged
4 tasks
This was referenced Apr 25, 2022
Merged
Closed
@elasticmachine
Copy link

elasticmachine commented Apr 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.538
Classes 100.0% (3/3) 💚 3.538
Methods 100.0% (27/27) 💚 10.641
Lines 100.0% (166/166) 💚 9.242
Conditionals 100.0% (0/0) 💚

agithomas
agithomas reviewed May 2, 2022
View reviewed changes
packages/oracle_weblogic/data_stream/domain/manifest.yml Outdated
required: true
show_user: true
default:
- /tmp/service_logs/logs/my_domain.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the default path as with the case of admin server log. DOMAIN_HOME/servers/AdminServer/logs

Default path reference here : https://docs.oracle.com/cd/E40518_01/server.761/es_admin/src/tadm_logging_access_log.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore the reference url above, it is related to access log path

packages/oracle_weblogic/data_stream/domain/fields/fields.yml Outdated
description: Machine Name is the DNS name of the computer that hosts the server instance.
- name: message_id
type: keyword
description: A unique six-digit identifier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the same convention as with admin server log

packages/oracle_weblogic/data_stream/domain/elasticsearch/ingest_pipeline/default.yml Show resolved Hide resolved
@kush-elastic kush-elastic added enhancement New feature or request New Integration Team:Service-Integrations Label for the Service Integrations team labels May 3, 2022
@kush-elastic kush-elastic mentioned this pull request May 5, 2022
Closed
4 tasks
agithomas
agithomas reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@kush-elastic
Minor Update to Tags Configuration
561ed36
@kush-elastic
nits
20f65b9
@kush-elastic
Update system test
6c6fc21
@kush-elastic
Merge branch 'main' of https://github.com/elastic/integrations into p…
abf3545 
…ackage_oracle_weblogic_domain

Conflicts:
	packages/oracle_weblogic/_dev/build/build.yml
	packages/oracle_weblogic/_dev/build/docs/README.md
	packages/oracle_weblogic/_dev/deploy/docker/docker-compose.yml
	packages/oracle_weblogic/_dev/deploy/docker/oracle_weblogic/container-scripts/generateAccess.sh
	packages/oracle_weblogic/_dev/deploy/docker/oracle_weblogic/container-scripts/startAdminServer.sh
	packages/oracle_weblogic/_dev/deploy/docker/oracle_weblogic/container-scripts/startManagedServer.sh
	packages/oracle_weblogic/changelog.yml
	packages/oracle_weblogic/docs/README.md
	packages/oracle_weblogic/img/oracle_weblogic-logs-overview.png
	packages/oracle_weblogic/kibana/dashboard/oracle_weblogic-4b2b0170-b88a-11ec-b6f8-0795d197226b.json
	packages/oracle_weblogic/manifest.yml
@kush-elastic kush-elastic requested a review from a team as a code owner May 23, 2022 06:26
yug-rajani
yug-rajani approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/oracle_weblogic/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@yug-rajani yug-rajani requested a review from agithomas May 23, 2022 07:01
agithomas
agithomas reviewed May 26, 2022
View reviewed changes
packages/oracle_weblogic/data_stream/domain/manifest.yml Outdated
show_user: true
default:
- /user_projects/wls_domain/my_domain/servers/AdminServer/logs/wls_domain.log
description: The default path in WebLogic for Domain logs is $DOMAIN_NAME/servers/ADMIN_SERVER_NAME/logs/DOMAIN_NAME.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have consistency : Please change from $DOMAIN_NAME to DOMAIN_NAME

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per admin_server and managed_server logs PR description we have $DOMAIN_HOME.

Could you please let me know with what should I refer for making it consistent?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i already mentioned, please change from $DOMAIN_NAME to DOMAIN_NAME in the description

packages/oracle_weblogic/docs/README.md Show resolved Hide resolved
agithomas
agithomas approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yug-rajani yug-rajani merged commit c0840c3 into elastic:main May 27, 2022
@yug-rajani yug-rajani linked an issue Jun 7, 2022 that may be closed by this pull request
Oracle Weblogic Integration #2823
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@yug-rajani yug-rajani yug-rajani approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees
No one assigned
Labels
enhancement New feature or request Integration:oracle_weblogic Oracle WebLogic New Integration Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oracle Weblogic Integration
5 participants
@kush-elastic @elasticmachine @yug-rajani @agithomas @masci