Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure Metrics Readme #3077

Merged
merged 6 commits into from
Jun 13, 2022
Merged

Update Azure Metrics Readme #3077

merged 6 commits into from
Jun 13, 2022

Conversation

ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 12, 2022 •
edited
Loading

Corrected links to Microsoft documentation

Type of change

  • Enhancement

What does this PR do?

Corrected links to Microsoft documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
Update Readme
22e0fd4 
Corrected links to Microsoft documentation
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 12, 2022 15:13
@elasticmachine
Copy link

elasticmachine commented Apr 12, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T13:26:16.754+0000

  • Duration: 16 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 131
Skipped 0
Total 131

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ellis-elastic ellis-elastic marked this pull request as draft April 13, 2022 15:10
@ellis-elastic ellis-elastic added the documentation Improvements or additions to documentation label Apr 14, 2022
@ellis-elastic ellis-elastic marked this pull request as ready for review April 19, 2022 14:17
@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.589
Classes 100.0% (0/0) 💚 3.589
Methods 59.259% (16/27) 👎 -29.029
Lines 100.0% (0/0) 💚 10.983
Conditionals 100.0% (0/0) 💚

@ruflin ruflin added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Jun 8, 2022
tommyers-elastic
tommyers-elastic approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@tommyers-elastic tommyers-elastic merged commit 4993564 into elastic:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ellis-elastic @elasticmachine @bmorelli25 @tommyers-elastic @ruflin