-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netskope] Fix: dropping event due to new response from Netskope API. #3110
Merged
andrewkroh
merged 5 commits into
elastic:main
from
vinit-chauhan:fix_netskope_event_drop
Apr 15, 2022
Merged
[netskope] Fix: dropping event due to new response from Netskope API. #3110
andrewkroh
merged 5 commits into
elastic:main
from
vinit-chauhan:fix_netskope_event_drop
Apr 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinit-chauhan
changed the title
[Netskope] Fix: dropping event due to new response from Netskope API.
[netskope] Fix: dropping event due to new response from Netskope API.
Apr 15, 2022
/test |
andrewkroh
added
bug
Something isn't working, use only for issues
Team:Security-External Integrations
Integration:netskope
Netskope
labels
Apr 15, 2022
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
reviewed
Apr 15, 2022
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
/test |
/test |
andrewkroh
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the Netskope response previously the response had
true
as a value for the fieldnetskope.events.user.generated
. Now the API response is updated to sendyes
instead, resulting in the pipeline failure.In this PR we have added conversions for true/false and yes/no to all the boolean fields so that such API changes for other fields can also be handled.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Clone integrations repo.
Install elastic-package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/netskope directory.
Run the following command to run tests.
elastic-package test
Related issues
Screenshots