Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netskope] Fix: dropping event due to new response from Netskope API. #3110

Merged
merged 5 commits into from
Apr 15, 2022

Conversation

vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Apr 15, 2022

What does this PR do?

In the Netskope response previously the response had true as a value for the field netskope.events.user.generated. Now the API response is updated to send yes instead, resulting in the pipeline failure.

In this PR we have added conversions for true/false and yes/no to all the boolean fields so that such API changes for other fields can also be handled.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Clone integrations repo.
Install elastic-package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/netskope directory.
Run the following command to run tests.
elastic-package test

Related issues

Screenshots

image
image

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner April 15, 2022 05:30
@elasticmachine
Copy link

elasticmachine commented Apr 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-15T15:31:33.388+0000

  • Duration: 14 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 110
Skipped 0
Total 110

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@vinit-chauhan vinit-chauhan changed the title [Netskope] Fix: dropping event due to new response from Netskope API. [netskope] Fix: dropping event due to new response from Netskope API. Apr 15, 2022
@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:netskope Netskope labels Apr 15, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

vinit-chauhan and others added 2 commits April 15, 2022 20:14
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@andrewkroh
Copy link
Member

/test

@andrewkroh
Copy link
Member

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:netskope Netskope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Netskope] Dropping event due to parsing error
3 participants