-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mimecast] Cleanup field mappings and package description #3193
Merged
andrewkroh
merged 18 commits into
elastic:main
from
andrewkroh:mimecast/cleanup-mappings
Apr 26, 2022
Merged
[mimecast] Cleanup field mappings and package description #3193
andrewkroh
merged 18 commits into
elastic:main
from
andrewkroh:mimecast/cleanup-mappings
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[git-generate] cd packages/mimecast for i in $(find . -name ecs.yml); do yq -i '. | sort_keys(..) | sort_by(.name)' $i; done
Use ECS fields for audit_logs. Remove unused source.as.{asn,organization_name}.
Use ECS fields for dlp_logs. None of the mimecast.* fields are used so remove the mappings.
Use ECS fields in siem_logs. Remove email.message_size and email.header_from which are not part of ECS. Use mimecast.MsgSize and email.from.address instead. Remove source.as.asn and source.as.organization_name and use the correct ECS fields.
Add missing ECS event fields.
Add missing ECS event field mappings.
Use ECS field definitions for ttp_ap_logs. It was using email.attachments.hash which is not a valid ECS field so I changed it to use email.attachments.file.hash.sha256.
[git-generate] cd packages/mimecast elastic-package test pipeline -g -d=ttp_ap_logs
Use ECS field definitions for ttp_ip_logs. Add missing event.created mapping.
Use ECS fields for ttp_url_logs. Add missing event.created mapping.
And fix a typo in mime_type.
[git-generate] cd packages/mimecast elastic-package build
andrewkroh
force-pushed
the
mimecast/cleanup-mappings
branch
from
April 26, 2022 02:39
f4441d9
to
79f69f0
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
reviewed
Apr 26, 2022
packages/mimecast/data_stream/siem_logs/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
🌐 Coverage report
|
efd6
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
allow_duplicates: false
toemail.{to,from}.address
append processors.Checklist
changelog.yml
file.