Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbon Black Cloud] Update the title of CBC connector. #3196

Merged

Conversation

vinit-chauhan
Copy link
Contributor

What does this PR do?

This PR updates the title to VMware Carbon Black Cloud from Carbon Black Cloud to make it consistent with other VMware Carbon Black products.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

image
image

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-26T13:34:05.402+0000

  • Duration: 15 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 97
Skipped 0
Total 97

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.941
Classes 100.0% (5/5) 💚 2.941
Methods 96.825% (61/63) 👍 9.044
Lines 94.814% (1170/1234) 👍 6.236
Conditionals 100.0% (0/0) 💚

@vinit-chauhan
Copy link
Contributor Author

/test

license: basic
description: This Elastic integration collects logs from Carbon Black Cloud
description: This Elastic integration collects logs from VMware Carbon Black Cloud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: This Elastic integration collects logs from VMware Carbon Black Cloud
description: Collect logs from VMWare Carbon Black Cloud with Elastic Agent.

changes:
- description: Updated the package title in Manifest and README file to make it consistent with other VMware Carbon Black products.
type: enhancement
link: https://github.com/elastic/integrations/pull/xxxx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/xxxx
link: https://github.com/elastic/integrations/pull/3196

@@ -1,4 +1,9 @@
# newer versions go on top
- version: 0.1.2
changes:
- description: Updated the package title in Manifest and README file to make it consistent with other VMware Carbon Black products.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:

Suggested change
- description: Updated the package title in Manifest and README file to make it consistent with other VMware Carbon Black products.
- description: Add "VMware" to the title to make it "VMware Carbon Black Cloud".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:carbon_black_cloud VMware Carbon Black Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Carbon Black Cloud] Update the title of the CBC integration to 'VMware Carbon Black Cloud'
3 participants