Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proofpoint_tap] Add Proofpoint TAP package #3201

Merged
merged 4 commits into from
May 25, 2022

Conversation

darshan-elastic
Copy link
Contributor

What does this PR do?

  • Generated the skeleton of the Proofpoint TAP integration package.
  • Added a data stream.
  • Added data collection logic to the data stream.
  • Added the ingest pipeline for the data stream.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files
  • Added dashboards and visualizations.
  • Added test for pipeline for the data stream.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/proofpoint_tap directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

image
image
image
image

@darshan-elastic
Copy link
Contributor Author

/test

@elasticmachine
Copy link

elasticmachine commented Apr 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T13:24:44.361+0000

  • Duration: 18 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 53
Skipped 0
Total 53

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 26, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.589
Classes 100.0% (4/4) 💚 3.589
Methods 100.0% (62/62) 💚 11.711
Lines 98.179% (1078/1098) 👍 9.161
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh requested a review from a team April 26, 2022 21:46
@darshan-elastic
Copy link
Contributor Author

@jamiehynds @andrewkroh This integration has been tested using a mock server.

@darshan-elastic
Copy link
Contributor Author

/test

@andrewkroh
Copy link
Member

andrewkroh commented May 6, 2022

event.created is missing a definition in the fields files.

--- Test results for package: proofpoint_tap - START ---
FAILURE DETAILS:
proofpoint_tap/clicks_blocked Verify sample_event.json:
[0] field "event.created" is undefined
proofpoint_tap/clicks_permitted Verify sample_event.json:
[0] field "event.created" is undefined
proofpoint_tap/message_blocked Verify sample_event.json:
[0] field "event.created" is undefined
proofpoint_tap/message_delivered Verify sample_event.json:
[0] field "event.created" is undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants