Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Netskope Readme #3220

Merged
merged 7 commits into from
Jun 16, 2022
Merged

Update Netskope Readme #3220

merged 7 commits into from
Jun 16, 2022

Conversation

ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 28, 2022 •
edited
Loading

What does this PR do?

removed Italic text in hyperlinks

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
Update README.md
380fe9d 
Changed headings to correct markdown syntax
@ellis-elastic
Revert "Update README.md"
e878703 
This reverts commit 380fe9d.
@ellis-elastic
update readme
10a052a 
removed Italic text in hyperlinks
@ellis-elastic
Update Netskope readme
85c685f 
Removed space
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation enhancement New feature or request docs labels Apr 28, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 28, 2022 15:22
@elasticmachine
Copy link

elasticmachine commented Apr 28, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-16T13:07:14.015+0000

  • Duration: 16 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 110
Skipped 0
Total 110

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 28, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.432
Classes 100.0% (2/2) 💚 3.432
Methods 96.296% (26/27) 👍 7.387
Lines 57.328% (266/464) 👎 -32.618
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor fixes.

packages/netskope/changelog.yml Show resolved Hide resolved
packages/netskope/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@ellis-elastic ellis-elastic merged commit 4700227 into elastic:main Jun 16, 2022
@ellis-elastic ellis-elastic deleted the Netskope branch June 16, 2022 21:14
@andrewkroh andrewkroh mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
docs documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ellis-elastic @elasticmachine @bmorelli25 @efd6 @epixa