Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws.dimensions.* for rds data stream #3253

Merged
merged 4 commits into from
May 5, 2022
Merged

Fix aws.dimensions.* for rds data stream #3253

merged 4 commits into from
May 5, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 2, 2022

What does this PR do?

This PR is to fix the RDS dimension fields in fields.yml file. When collecting dimension information from CloudWatch, if there are more than one dimension key, these keys are separated into different dimensions with their own entries. For example: dimension DBClusterIdentifier, Role will separate into aws.dimesnions.DBClusterIdentifier and aws.dimensions.Role.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner May 2, 2022 17:28
@kaiyan-sheng kaiyan-sheng self-assigned this May 2, 2022
@elasticmachine
Copy link

elasticmachine commented May 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-03T15:02:14.644+0000

  • Duration: 31 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 2, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.147
Classes 91.667% (11/12) 👎 -5.147
Methods 82.439% (169/205) 👎 -5.873
Lines 92.66% (2083/2248) 👍 3.731
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label May 5, 2022
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have never seen this syntax with comma-separated field names before:

      fields:
        - name: DBClusterIdentifier, Role
          type: keyword

Where can I learn more?

@kaiyan-sheng kaiyan-sheng merged commit 535d24a into elastic:main May 5, 2022
@kaiyan-sheng kaiyan-sheng deleted the rds_dimensions branch May 5, 2022 14:00
@kaiyan-sheng
Copy link
Contributor Author

@zmoog We don't have this actually supported in aws integration. Not sure why it got into the fields.yml for dimensions 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants