Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fortinet] Separate Fortinet FortiClient into own Integration #3268

Merged
merged 8 commits into from
Jul 24, 2022
Merged

[Fortinet] Separate Fortinet FortiClient into own Integration #3268

merged 8 commits into from
Jul 24, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Separate Fortinet FortiClient into own Integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented May 4, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-11T00:57:36.744+0000

  • Duration: 18 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000
Copy link
Contributor Author

@andrewkroh ready for testing

@efd6
Copy link
Contributor

efd6 commented Jun 28, 2022

/test

1 similar comment
@efd6
Copy link
Contributor

efd6 commented Jun 28, 2022

/test

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. labels Jun 28, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Jun 28, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Jun 29, 2022

/test

@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.024
Classes 100.0% (1/1) 💚 3.024
Methods 77.778% (7/9) 👎 -12.094
Lines 82.143% (46/56) 👎 -8.864
Conditionals 100.0% (0/0) 💚

@legoguy1000
Copy link
Contributor Author

I found and fixed the issues

@efd6
Copy link
Contributor

efd6 commented Jul 11, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Jul 11, 2022

/test

@efd6 efd6 merged commit 849b26a into elastic:main Jul 24, 2022
@legoguy1000 legoguy1000 deleted the 1936-fortinet-forticlient branch July 25, 2022 01:25
@andrewkroh andrewkroh mentioned this pull request Jul 26, 2022
Merged
@efd6 efd6 mentioned this pull request Aug 25, 2022
Open
15 tasks
@andrewkroh andrewkroh removed the Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:fortinet_forticlient Fortinet FortiClient Logs New Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legoguy1000 @elasticmachine @efd6 @andrewkroh