Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Move VPN configuration file into integrations and add tag collection #3305

Merged
merged 3 commits into from
May 11, 2022
Merged

[AWS] Move VPN configuration file into integrations and add tag collection #3305

merged 3 commits into from
May 11, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 9, 2022

What does this PR do?

This PR is to move VPN configuration file into integrations repo and also added the config for collecting tags.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner May 9, 2022 21:07
@kaiyan-sheng kaiyan-sheng self-assigned this May 9, 2022
@elasticmachine
Copy link

elasticmachine commented May 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-11T15:17:36.558+0000

  • Duration: 27 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 9, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -4.745
Classes 91.667% (11/12) 👎 -4.745
Methods 82.439% (169/205) 👎 -5.845
Lines 92.673% (2087/2252) 👍 3.645
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label May 11, 2022
@kaiyan-sheng kaiyan-sheng merged commit ed37d9a into elastic:main May 11, 2022
@kaiyan-sheng kaiyan-sheng deleted the vpn_tags branch May 11, 2022 15:48
@zmoog
Copy link
Contributor

zmoog commented May 11, 2022

Oh, I missed the changelog anche the package version, next time I will pay more attention! 😅

@kaiyan-sheng
Copy link
Contributor Author

Oh, I missed the changelog anche the package version, next time I will pay more attention! 😅

@zmoog Hey not your fault haha I did it on purpose so I don't have to fix merge conflict 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants