Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cisco_ios] Add TCP input with TLS support #3314

Merged
merged 2 commits into from
May 11, 2022
Merged

[cisco_ios] Add TCP input with TLS support #3314

merged 2 commits into from
May 11, 2022

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 10, 2022 •
edited
Loading

What does this PR do?

  • Add TCP input, with TLS and custom options support
  • Add system test for TCP input

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_ios && elastic-package test

Related issues

Screenshots

cisco_ios

@taylor-swanson
[cisco_ios] Add TCP input with TLS support
0980fda 
- Add TCP input, with TLS and custom options support
- Add system test for TCP input
@taylor-swanson taylor-swanson self-assigned this May 10, 2022
@elasticmachine
Copy link

elasticmachine commented May 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-10T15:31:57.171+0000

  • Duration: 20 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 10, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.14
Classes 100.0% (1/1) 💚 3.14
Methods 100.0% (14/14) 💚 11.558
Lines 90.672% (243/268) 👍 1.572
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review May 10, 2022 13:52
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 10, 2022 13:52
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

r00tu53r
r00tu53r approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylor-swanson taylor-swanson merged commit acf7580 into elastic:main May 11, 2022
@taylor-swanson taylor-swanson deleted the inputs-cisco-ios branch May 11, 2022 13:24
This was referenced May 22, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r00tu53r r00tu53r r00tu53r approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
8.3-candidate enhancement New feature or request Integration:cisco_ios Cisco IOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylor-swanson @elasticmachine @r00tu53r