-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[juniper_srx] Improve TCP input #3320
[juniper_srx] Improve TCP input #3320
Conversation
- Add TLS support to TCP input - Add custom TCP options support
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be a TLS test?
I thought about it originally and was overthinking the complexity of setting that up. I just tested it and it turns out it's trivial to set up and hard code the cert/key pair (we won't test validating certificates). I'll add a TLS test here and to the other packages as well. |
TLS test has been added. |
What does this PR do?
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots