-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gcp]: Preserve gcp field data in flattened fields #3390
Merged
r00tu53r
merged 12 commits into
elastic:main
from
r00tu53r:feat/gcp-record-all-fields-ecs-update
May 20, 2022
Merged
[gcp]: Preserve gcp field data in flattened fields #3390
r00tu53r
merged 12 commits into
elastic:main
from
r00tu53r:feat/gcp-record-all-fields-ecs-update
May 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update protoPayload.request and protoPayload.response to flattened - Update logic to convert callerIp to source.ip - Remove request.proto_name or response.proto_name and use @type
- Drop document if it is not an AuditLog type - comment pipeline code with links to GCP object types - reordered pipeline consolidate processing for each object type - set event.provider (based on 4 documented types) - changed convert to rename where it was unnecessary - set orchestrator.type for gke_cluster (in addition to k8s_cluster) - authentication_info.principalemail -> client.user.email - authentication_info.principalSubject -> client.user.id - convert to source.ip only when it is not 'gce-internal-ip' - add handling for LogEntryOperation (set event.category and event.type) for long running operations - save operation.id to gcp.audit.logentry_operation.id only if it is not the same as .insertId - set event.category and event.type to network,configuration => allowed|denied based on authorization_info.resource[].granted - add ecs fields
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
reviewed
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to run elastic-packge build
.
packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
🌐 Coverage report
|
/test |
efd6
approved these changes
May 20, 2022
/test |
This was referenced May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
protoPayload.request
andprotoPayload.response
in flattened fieldsallowed|denied based on authorization_info.resource[].granted
Checklist
changelog.yml
file.How to test this PR locally
elastic-package test pipeline -v -g
elastic-package test system -v -g
Related issues
Closes #2857