Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cef: clarify the scope of existing dashboards #3470

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 6, 2022

What does this PR do?

The dashboards that exist were originally ArcSight dashboards and have not been
updated to work with other CEF inputs, so note in the names and descriptions that
they are for ArcSight.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screen Shot 2022-06-06 at 10 36 28

@efd6 efd6 added bug Something isn't working, use only for issues documentation Improvements or additions to documentation Team:Security-External Integrations Integration:cef Common Event Format (CEF) labels Jun 6, 2022
@efd6 efd6 self-assigned this Jun 6, 2022
The dashboards that exist were originally ArcSight dashboards and have not been
updated to work with other CEF inputs, so note in the names and descriptions that
they are for ArcSight.
@efd6 efd6 force-pushed the 3469-arcsight_cef/rename branch from 253703e to 43b093d Compare June 6, 2022 01:16
@efd6 efd6 marked this pull request as ready for review June 6, 2022 01:16
@efd6 efd6 requested a review from a team as a code owner June 6, 2022 01:16
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-06T01:16:28.082+0000

  • Duration: 15 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 84
Skipped 0
Total 84

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.513
Classes 100.0% (3/3) 💚 3.513
Methods 95.0% (19/20) 👍 5.495
Lines 89.286% (400/448) 👎 -1.501
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues documentation Improvements or additions to documentation Integration:cef Common Event Format (CEF)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants