Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network_traffic: add mappings for process.* fields #3515

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 16, 2022

What does this PR do?

Adds mappings for process.* fields at the root level.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • I have added the fields to all the data streams and not just the 4 that were noted in the issue since the beat field.yml includes process.* in the common set.

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:network_traffic Network Packet Capture labels Jun 16, 2022
@efd6 efd6 self-assigned this Jun 16, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-29T00:36:54.944+0000

  • Duration: 73 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 264
Skipped 0
Total 264

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 16, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.401
Classes 100.0% (0/0) 💚 3.401
Methods 71.875% (46/64) 👎 -16.987
Lines 100.0% (0/0) 💚 10.053
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 16, 2022 09:37
@efd6 efd6 requested a review from a team as a code owner June 16, 2022 09:37
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor Author

efd6 commented Jun 29, 2022

It would be nice if process.* could be placed on server and client according to ECS.

@efd6 efd6 merged commit 12529d0 into elastic:main Jun 29, 2022
@efd6 efd6 deleted the 3512-network_traffic branch June 29, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:network_traffic Network Packet Capture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[network_traffic] process.start is missing from mappings
3 participants