Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] Rule template schema changes - introducing metadata field #3561

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

kfirpeled
Copy link
Contributor

What does this PR do?

In version 8.4.0 we've refactored the schema of csp-rule-template and introduced a new metadata field to hold all the static information

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jun 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-28T15:58:02.991+0000

  • Duration: 18 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 22, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.409
Classes 100.0% (0/0) 💚 3.409
Methods 33.333% (1/3) 👎 -55.487
Lines 100.0% (0/0) 💚 10.064
Conditionals 100.0% (0/0) 💚

@kfirpeled kfirpeled marked this pull request as ready for review June 26, 2022 21:31
@kfirpeled kfirpeled requested a review from a team as a code owner June 26, 2022 21:31
@kfirpeled kfirpeled requested a review from CohenIdo June 28, 2022 16:22
@kfirpeled kfirpeled merged commit bf8e3e3 into elastic:main Jun 28, 2022
@kfirpeled kfirpeled deleted the cspm/v840-rule-metadata branch June 28, 2022 17:12
@kfirpeled kfirpeled changed the title [Cloud Posture] Migrating rule template schema [Cloud Posture] Rule template schema changes - introducing metadata field Jun 28, 2022
@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants