Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[activemq] Update ActiveMQ package #3591

Merged
merged 16 commits into from
Jul 20, 2022
Merged

[activemq] Update ActiveMQ package #3591

merged 16 commits into from
Jul 20, 2022

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Jun 27, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

  • Updated integration package to follow all the best practices.
  • Updated system test to 5.17.1 version of ActiveMQ.
  • Updated dashboards of all data streams.
  • Fixed minor bugs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/activemq directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

filebeat-activemq-audit-events

metricbeat-activemq-broker-overview

filebeat-activemq-application-events

metricbeat-activemq-topics-overview

metricbeat-activemq-queues-overview

@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T09:36:54.053+0000

  • Duration: 22 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.074
Classes 100.0% (2/2) 💚 3.074
Methods 95.833% (23/24) 👍 6.276
Lines 83.838% (83/99) 👎 -7.578
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic self-assigned this Jun 28, 2022
@kush-elastic kush-elastic added enhancement New feature or request Integration:activemq ActiveMQ Team:Service-Integrations Label for the Service Integrations team labels Jun 28, 2022
@kush-elastic kush-elastic changed the title Package activemq [activemq] Update package Jun 28, 2022
@kush-elastic kush-elastic changed the title [activemq] Update package [activemq] Update ActiveMQ package Jun 28, 2022
@kush-elastic kush-elastic removed the request for review from lalit-satapathy June 28, 2022 06:09
@kush-elastic kush-elastic marked this pull request as ready for review June 28, 2022 13:23
@kush-elastic kush-elastic requested a review from a team as a code owner June 28, 2022 13:23
yug-rajani
yug-rajani approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Provided one nit.

packages/activemq/data_stream/broker/fields/fields.yml Outdated Show resolved Hide resolved
@muthu-mps
Copy link
Contributor

Please update the documentation. This line needs to be edited. _logs created by the ActiveMQ server - system logs and audit logs._. and include few more details about the custom configurations for ActiveMQ if any.

@muthu-mps
Copy link
Contributor

Logs Dashboard, Please rename the title _ERROR_ to lowercase.

yug-rajani
yug-rajani reviewed Jul 7, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided some nits

packages/activemq/data_stream/audit/manifest.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/log/manifest.yml Outdated Show resolved Hide resolved
packages/activemq/manifest.yml Outdated Show resolved Hide resolved
packages/activemq/manifest.yml Outdated Show resolved Hide resolved
muthu-mps
muthu-mps approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 871485a into elastic:main Jul 20, 2022
@bhagyaraj-crest bhagyaraj-crest mentioned this pull request Jul 22, 2022
Merged
4 tasks
@kush-elastic kush-elastic mentioned this pull request Sep 20, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yug-rajani yug-rajani yug-rajani approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@kush-elastic kush-elastic

Labels
enhancement New feature or request Integration:activemq ActiveMQ Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kush-elastic @elasticmachine @muthu-mps @yug-rajani