Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis enterprise Integration- Beta package #3617

Merged
merged 12 commits into from
Jul 12, 2022
Merged

Redis enterprise Integration- Beta package #3617

merged 12 commits into from
Jul 12, 2022

Conversation

lalit-satapathy
Copy link
Collaborator

@lalit-satapathy lalit-satapathy commented Jun 29, 2022 •
edited
Loading

What does this PR do?

Redis Enterprise Integration beta release. Closes #3457

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Pending Items

How to test this PR locally

  • Docker install redislabs/redis:5.2.2-24
  • Create a dummy node and database
  • Ensure that the prometheus port (8070) is exported
  • Pass the host:8070 to the integration hosts

Related issues

Screenshots

redisenterprise-dashboard

@lalit-satapathy lalit-satapathy added enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team 8.4 candidate labels Jun 29, 2022
@lalit-satapathy lalit-satapathy requested a review from a team June 29, 2022 05:49
@lalit-satapathy lalit-satapathy self-assigned this Jun 29, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-12T07:38:38.053+0000

  • Duration: 15 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.145
Classes 100.0% (0/0) 💚 3.145
Methods 50.0% (4/8) 👎 -39.567
Lines 100.0% (0/0) 💚 8.936
Conditionals 100.0% (0/0) 💚

muthu-mps
muthu-mps reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metric names which appears inside the visualisation can be removed. Like system, user, Free Memory which is already part of the title.

@muthu-mps muthu-mps self-requested a review June 30, 2022 04:45
@lalit-satapathy
Dashboard by value.
26f5e1f 
Remove node_ from redisenterprise.node.
Update sample event.
Other minor changes.
@lalit-satapathy
updated image.
efe230b
@lalit-satapathy
ecs.verion.
7d7430d
@lalit-satapathy lalit-satapathy marked this pull request as ready for review July 6, 2022 06:02
@lalit-satapathy
Copy link
Collaborator Author

The metric names which appears inside the visualisation can be removed. Like system, user, Free Memory which is already part of the title.

Making it empty causes some issue, so we need some description there.

@muthu-mps muthu-mps self-requested a review July 12, 2022 10:52
muthu-mps
muthu-mps approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lalit-satapathy lalit-satapathy merged commit f3234e8 into elastic:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

@lalit-satapathy lalit-satapathy

Labels
8.4 candidate enhancement New feature or request Integration:redisenterprise Redis Enterprise New Integration Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Redis Enterprise Integration
5 participants
@lalit-satapathy @elasticmachine @muthu-mps @ishleenk17 @andrewkroh