Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EKS input type to the cloud security posture integration #3619

Merged

Conversation

ofiriro3
Copy link
Contributor

@ofiriro3 ofiriro3 commented Jun 29, 2022

What does this PR do?

This PR is enhancing the current Cloud security posture integration by adding another input type that supports collecting findings against an EKS cluster.
The new input type defines new input fields AKA the AWS credentials that should be sent as part of creating the integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ofiriro3 ofiriro3 added the enhancement New feature or request label Jun 29, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-04T14:10:00.151+0000

  • Duration: 17 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ofiriro3 ofiriro3 marked this pull request as ready for review June 29, 2022 12:07
@ofiriro3 ofiriro3 requested a review from a team as a code owner June 29, 2022 12:07
@@ -1,6 +1,28 @@
title: "Findings"
type: logs
streams:
- input: cloudbeat
- input: cloudbeat/vanilla
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to verify before merging it, that the integration is part of the ELK release candidate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not part of the official release but we set the integration to work only with 8.4 version so no worries regrading it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attached here is the backward compatibility matrix as a reminder, indeed that makes that incompatible with 8.3.0 agents.

As you mentioned, this version is available from kibana.version 8.4.0 only, so no issue here.

Screen Shot 2022-01-24 at 11 48 25 (1)

@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 4.059
Classes 100.0% (0/0) 💚 4.059
Methods 33.333% (1/3) 👎 -54.523
Lines 100.0% (0/0) 💚 12.508
Conditionals 100.0% (0/0) 💚

@ofiriro3 ofiriro3 self-assigned this Jun 29, 2022
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
do not merge before elastic/elastic-agent#638

@@ -1,6 +1,28 @@
title: "Findings"
type: logs
streams:
- input: cloudbeat
- input: cloudbeat/vanilla
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attached here is the backward compatibility matrix as a reminder, indeed that makes that incompatible with 8.3.0 agents.

As you mentioned, this version is available from kibana.version 8.4.0 only, so no issue here.

Screen Shot 2022-01-24 at 11 48 25 (1)

@ofiriro3 ofiriro3 requested a review from kfirpeled July 3, 2022 11:20
@ofiriro3 ofiriro3 merged commit 91aadb9 into elastic:main Jul 4, 2022
@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.4 candidate enhancement New feature or request Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants