Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_asa: fix handling of user parsing with sgt fields #3650

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 5, 2022

What does this PR do?

This fixes handling of user parsing when there are SGT fields associated with the user and dissects the destination user from the domain in 302013 and 302015 events.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_asa Cisco ASA labels Jul 5, 2022
@efd6 efd6 requested a review from a team as a code owner July 5, 2022 04:37
@efd6 efd6 self-assigned this Jul 5, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-05T04:38:50.963+0000

  • Duration: 16 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.529
Classes 100.0% (1/1) 💚 3.529
Methods 94.444% (17/18) 👍 5.136
Lines 63.842% (1130/1770) 👎 -27.1
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cisco_asa Cisco ASA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants