Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk and Cloudflare] Fix indefinite pagination #3651

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jul 5, 2022

What does this PR do?

There was no condition for pagination to end even if a page was empty, this PR adds checks for response body count, and errors out if its empty to end the pagination.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:snyk Snyk Integration:cloudflare Cloudflare labels Jul 5, 2022
@P1llus P1llus requested a review from a team as a code owner July 5, 2022 07:01
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-05T07:01:41.776+0000

  • Duration: 16 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 106
Skipped 0
Total 106

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (5/5) 💚 3.529
Classes 100.0% (5/5) 💚 3.529
Methods 100.0% (57/57) 💚 10.691
Lines 94.332% (882/935) 👍 3.389
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cloudflare Cloudflare Integration:snyk Snyk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants