Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Haproxy] Add TLS fields to HAProxy #3678

Merged
merged 6 commits into from
Oct 20, 2022
Merged

[Haproxy] Add TLS fields to HAProxy #3678

merged 6 commits into from
Oct 20, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jul 11, 2022 •
edited
Loading

What does this PR do?

  • Add TLS fields for HTTPS requests
  • Update ECS to 8.4.0
  • Add additional test data

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner July 11, 2022 13:50
@legoguy1000 legoguy1000 mentioned this pull request Jul 11, 2022
Open
@elasticmachine
Copy link

elasticmachine commented Jul 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T23:29:53.475+0000

  • Duration: 15 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jul 11, 2022

/test

@elasticmachine
Copy link

elasticmachine commented Jul 11, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.496
Classes 100.0% (1/1) 💚 2.496
Methods 90.476% (19/21) 👍 0.144
Lines 90.556% (163/180) 👎 -1.081
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh added Integration:haproxy HAProxy Team:Service-Integrations Label for the Service Integrations team labels Aug 15, 2022
@legoguy1000
Copy link
Contributor Author

Can we merge this?

andrewkroh
andrewkroh approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh added the enhancement New feature or request label Aug 16, 2022
@andrewkroh
Copy link
Member

@elastic/obs-service-integrations can you take a look please?

@legoguy1000
Copy link
Contributor Author

I'll rebase this so we can merge

@legoguy1000
Copy link
Contributor Author

ready to merge

@legoguy1000
Copy link
Contributor Author

@andrewkroh Can we merge this?

@andrewkroh
Copy link
Member

@elastic/obs-service-integrations, can you please add your review?

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@legoguy1000
Copy link
Contributor Author

any update on merging this?

@legoguy1000
Copy link
Contributor Author

@kaiyan-sheng are u able to approve this?

@kaiyan-sheng
Copy link
Contributor

@legoguy1000 nope :) @ishleenk17 Could you take a look at this PR please? TIA!!

@legoguy1000
Copy link
Contributor Author

bump

ishleenk17
ishleenk17 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ishleenk17 ishleenk17 merged commit 200eaa9 into elastic:main Oct 20, 2022
@legoguy1000 legoguy1000 deleted the haproxy-https branch October 20, 2022 12:03
@ishleenk17 ishleenk17 assigned ishleenk17 and unassigned ishleenk17 Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:haproxy HAProxy Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legoguy1000 @elasticmachine @efd6 @andrewkroh @kaiyan-sheng @ishleenk17