Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_duo] Fix bad value in ip and date fields #3700

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Jul 13, 2022

Type of change

  • Enhancement

What does this PR do?

This PR adds support for handling bad values in ip and date fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

image
image
image
image

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner July 13, 2022 13:28
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T14:58:20.455+0000

  • Duration: 22 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 54
Skipped 0
Total 54

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 13, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 3.049
Classes 100.0% (5/5) 💚 3.049
Methods 100.0% (50/50) 💚 10.792
Lines 93.253% (622/667) 👍 3.048
Conditionals 100.0% (0/0) 💚

formats:
- UNIX
on_failure:
- append:
Copy link
Member

@andrewkroh andrewkroh Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the pipeline appends to error.message then the global on_failure should also be appending so that no messages are lost. Currently it uses set so it will overwrite this error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I missed it. I'll update it.

@andrewkroh
Copy link
Member

@vinit-elastic Is there test case with an IP field containing "None" already in the package?

@vinit-chauhan
Copy link
Contributor Author

vinit-chauhan commented Jul 15, 2022

@vinit-elastic Is there test case with an IP field containing "None" already in the package?

Hey @andrewkroh,
The reason we didn't add the log is that adding the log in the pipeline test would make the test fail with the following error.
unexpected pipeline error (unexpected error.message type []interface {}): ['None' is not an IP string literal.]

@andrewkroh
Copy link
Member

Ok, thanks. So in order to support this type of testing we need a way to ignore the error.message from the test config.

@vinit-chauhan vinit-chauhan self-assigned this Jul 20, 2022
@andrewkroh
Copy link
Member

Related: elastic/elastic-package#912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cisco_duo Cisco Duo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco Duo integration (v1.1.1) - fields are not getting mapped when auth_device.ip field has value "None"
3 participants