-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cisco_duo] Fix bad value in ip and date fields #3700
[cisco_duo] Fix bad value in ip and date fields #3700
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
formats: | ||
- UNIX | ||
on_failure: | ||
- append: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the pipeline appends to error.message
then the global on_failure
should also be appending so that no messages are lost. Currently it uses set
so it will overwrite this error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I missed it. I'll update it.
@vinit-elastic Is there test case with an IP field containing "None" already in the package? |
Hey @andrewkroh, |
Ok, thanks. So in order to support this type of testing we need a way to ignore the error.message from the test config. |
Related: elastic/elastic-package#912 |
Type of change
What does this PR do?
This PR adds support for handling bad values in ip and date fields.
Checklist
How to test this PR locally
Related issues
Screenshots