Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tcp, ssl config descriptions and examples #3763

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jul 19, 2022

What does this PR do?

  • Add link to SSL and TCP configuration doc page in config descriptions
  • Change SSL default example to a server example

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screen Shot 2022-07-19 at 11 54 07 AM

@elasticmachine
Copy link

elasticmachine commented Jul 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T13:32:35.545+0000

  • Duration: 27 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 282
Skipped 0
Total 282

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 19, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 98.095% (103/105)
Classes 98.095% (103/105)
Methods 97.649% (540/553)
Lines 84.783% (13773/16245)
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review July 19, 2022 19:47
@taylor-swanson taylor-swanson requested a review from a team as a code owner July 19, 2022 19:47
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:checkpoint Check Point Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD Integration:cisco_ios Cisco IOS Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. Integration:juniper_srx Juniper SRX Integration:sophos Sophos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SSL configuration description and example
3 participants