-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Convert GCP Firestore metricset from lightweight #3798
Merged
kaiyan-sheng
merged 3 commits into
elastic:main
from
legoguy1000:3722-gcp-firestore-lightweight
Sep 19, 2022
Merged
[GCP] Convert GCP Firestore metricset from lightweight #3798
kaiyan-sheng
merged 3 commits into
elastic:main
from
legoguy1000:3722-gcp-firestore-lightweight
Sep 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endorama
added
Integration:gcp
Google Cloud Platform
Team:Cloud-Monitoring
Label for the Cloud Monitoring team
labels
Aug 1, 2022
kaiyan-sheng
reviewed
Sep 9, 2022
legoguy1000
force-pushed
the
3722-gcp-firestore-lightweight
branch
from
September 9, 2022 19:48
be9dc83
to
41fced2
Compare
kaiyan-sheng
approved these changes
Sep 9, 2022
/test |
🌐 Coverage report
|
Seems good to merge? |
legoguy1000
force-pushed
the
3722-gcp-firestore-lightweight
branch
from
September 19, 2022 18:36
28d4e4a
to
76915c7
Compare
4 tasks
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
loadbalancing_logs |
3663 | 2801.12 | -861.88 (-30.77%) | 💔 |
To see the full report comment with /test benchmark fullreport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Convert GCP Firestore metricset from lightweight
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
gcp.firestore
data stream #3722Screenshots