Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[activemq] Update integration package to remove unnecessary fields #3882

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Jul 28, 2022

  • Bug

What does this PR do?

This PR contains a minor cleanup for ActiveMQ integration. It removes the 2 fields which were present in fields.yml . These two fields are activemq.log.log_stack_trace and activemq.log.message which are regrouped in error.stack_trace and message fields. Since these fields are replaced they are no longer required in fields.yml.
As we know that release tag got deprecated but recently got added by ellis-elastic in this PR , so removed that tag as a part of this bugfix PR
The changes which are made do not affect the existing functionality of the integration at all and are just a cleanup to the integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/activemq directory.
  • Run the following command to run tests.

elastic-package test

@kush-elastic kush-elastic added bug Something isn't working, use only for issues Integration:activemq ActiveMQ Team:Service-Integrations Label for the Service Integrations team labels Jul 28, 2022
@kush-elastic kush-elastic requested a review from a team as a code owner July 28, 2022 10:22
@kush-elastic kush-elastic self-assigned this Jul 28, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-28T10:26:19.340+0000

  • Duration: 19 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.953
Classes 100.0% (2/2) 💚 2.953
Methods 95.833% (23/24) 👍 6.193
Lines 83.838% (83/99) 👎 -7.606
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar self-requested a review August 23, 2022 05:12
@kush-elastic kush-elastic merged commit 17ecd34 into elastic:main Aug 23, 2022
@kush-elastic kush-elastic mentioned this pull request Sep 20, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:activemq ActiveMQ Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants