Update input types and vars to support runtime config #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
eyalkraft
reviewed
Aug 8, 2022
eyalkraft
approved these changes
Aug 8, 2022
eyalkraft
added
8.5-candidate
Team:Cloud Security
9 tasks
kfirpeled
approved these changes
Aug 14, 2022
| type: yaml | ||
| title: Rules Activation Yaml | ||
| title: Rules Activation |
There was a problem hiding this comment.
consider changing the title to Configuration used for evaluation or something similar that better describes this field
andrewkroh
added
the
Integration:cloud_security_posture
eyalkraft
reviewed
Aug 14, 2022
Co-authored-by: eyalkraft <63912106+eyalkraft@users.noreply.github.com>
oren-zohar
requested changes
Aug 14, 2022
Comment on lines
2
to
14
| - version: "0.0.27" | ||
| changes: | ||
| - description: Update input types and var name to support runtime config | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/3968 | ||
| - version: "0.0.26" | ||
| changes: | ||
| - description: Version bump | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/3997 | ||
| - description: Updates to KSPM Integration README | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/3964 |
There was a problem hiding this comment.
Since 0.0.26 wasn't promoted yet we can unify it under it, no?
There was a problem hiding this comment.
This pr introduces breaking changes so we want to promote version 0.26 to SNAPSHOT and only then merge this commit.
The Kibana version condition changed to ^8.5.0.
oren-zohar
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dataYamlvar toruntimeCfgChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots