-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] update packages dataset #4018
Conversation
🌐 Coverage report
|
For Logstash internal monitoring I had to add the lines below to
And for some reason the docker container name is I've tested this branch using local kibana with changes from elastic/kibana#137904 and everything looks ok, except for this standalone cluster. I'm trying to understand why this is there. I don't see some datastreams like |
Are these settings allowing the Agent to collect data or is it publishing data in
It seems dependent on the docker version you're running which makes the profiles difficult to share and probably not the best approach when it comes to installing packages. @matschaffer has similar issue when testing the elasticsearch package
The logstash service defined in _dev contains a standalone pipeline so that is expected, unless the Standalone Cluster view breaks
Interesting, I'm wondering if this happens in standalone metricbeat as well. We can track this as a separate ticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just couldn't verify ccr
and enrich
(because enrich fails).
The standalone cluster was fixed after setting the monitoring.cluster_uuid
on logstash.yml
I removed those config lines. The problem was actually the wrong logstash host I used. Even with those lines on the config file, |
Glad to hear it wasn't the settings from #4018 (comment) - those would be for internal collection which wouldn't exercise the agent at all. Also the hyphen and dash is a difference between docker-compose 1 (underscores) & 2 (hyphens). I was running 1 awhile ago, then switched to 2 to see if it would help at all with This is part of why I'm a little skeptical of the "canned profile" approach and would like to work on better elastic-package level support for additional services used in testing. There's already code in there that deals with docker-compose differences so I think we can probably deal with it at the golang layer more easily. |
Wondering we might have a new issue with the saved profile now. When I try to connect a
update: nm... just yet another potential manifestation of the low-docker-disk issue 🤦🏻
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to merge. The data stream names are as-expected. I wish we had a more complete stack to test with (ccr, logstash, beats, monitoring), but not sure how easy/hard that'd be with the current setup.
I'm catching some logstash docs that are showing up as "standalone" but they cause the UI just look "blank"
But I'm fairly certain that's up to elastic/kibana#137904 to fix.
One thing on my mind for this PR is the logs. I guess they don't really need a .stack_monitoring
datastream though since the shape won't be changing between now and platform observability.
Ah, and the connection failures are due to So many little things to iron out here but I think this PR is fine. |
This reverts commit f880aee.
Merging - the ghost standalone cluster will be fixed with elastic/kibana#140102 |
Summary
Closes #3929
This change updates the datasets of the Stack Monitoring packages to include a stack_monitoring part (ie
elasticsearch.stack_monitoring.node
. The identifier has two purposes: 1) clarify the intent of these datastreams 2) free the stack products namespaces for the upcoming PO initiative. Only the metrics are impacted because logs will be collected similarly in both SM and PO.The change also bumps elasticsearch, kibana and logstash package to their next major version while keeping their release to experimental until elastic/kibana#120415 is completed. This will allow the packages to be built into the registry so that we don't have to manually build them locally when testing. I thought that metrics mappings being aligned was a relevant milestone for the bump.
Testing
Service is up, please use ctrl+c to take it down
http://localhost:5602
and navigate to Stack Monitoring app. Elasticsearch, Kibana and Logstash section should be showing up with all their views populated. Inspect all the views and report anything bizarremetrics-*
data streams is formatted asmetrics-{product}.stack_monitoring.{metricset}