Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file.path field in cloudtrail data stream to use json.digestS3Object #4049

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Fix file.path field in cloudtrail data stream to use json.digestS3Object #4049

merged 3 commits into from
Aug 23, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 22, 2022 •
edited
Loading

What does this PR do?

This PR is to fix cloudtrail data stream ingest pipeline for getting file.path field. This field should from json.digestS3Object instead of json.previousDigestS3Object. Please see elastic/beats#32609 for more details.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner August 22, 2022 19:05
andrewkroh
andrewkroh approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs a changelog entry.

@elasticmachine
Copy link

elasticmachine commented Aug 22, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-22T19:24:40.082+0000

  • Duration: 33 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 162
Skipped 2
Total 164

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 22, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (13/13) 💚
Files 92.857% (13/14) 👎 -4.318
Classes 92.857% (13/14) 👎 -4.318
Methods 84.232% (203/241) 👎 -5.122
Lines 95.697% (5204/5438) 👍 4.78
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng self-assigned this Aug 22, 2022
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Aug 22, 2022
sayden
sayden approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 01cf9b4 into elastic:main Aug 23, 2022
@kaiyan-sheng kaiyan-sheng deleted the cloudtrail_file_path branch August 23, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@sayden sayden sayden approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @sayden @andrewkroh