Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[activemq] Add ECS fields #4104

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Aug 31, 2022

  • Enhancement

What does this PR do?

This pull request is raised to add some ECS fields to ActiveMQ package which could be useful for user experience. Following changes are made to enhance package.

  • Added event.category
  • Added event.kind
  • Added event.type
  • Updated ecs.yml with all the fields
  • Updated version to 0.4.3 in manifest.yml

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/activemq directory.
  • Run the following command to run tests.

@kush-elastic kush-elastic added enhancement New feature or request Integration:activemq ActiveMQ Team:Service-Integrations Label for the Service Integrations team labels Aug 31, 2022
@kush-elastic kush-elastic self-assigned this Aug 31, 2022
@elasticmachine
Copy link

elasticmachine commented Aug 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-15T11:27:55.354+0000

  • Duration: 19 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 31, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.597
Classes 100.0% (2/2) 💚 2.597
Methods 95.833% (23/24) 👍 6.838
Lines 85.321% (93/109) 👎 -5.108
Conditionals 100.0% (0/0) 💚

@yug-rajani yug-rajani marked this pull request as ready for review September 1, 2022 04:52
@yug-rajani yug-rajani requested a review from a team as a code owner September 1, 2022 04:52
@ishleenk17 ishleenk17 self-requested a review September 14, 2022 07:32
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kush-elastic kush-elastic merged commit bda09dc into elastic:main Sep 19, 2022
@kush-elastic kush-elastic mentioned this pull request Sep 20, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:activemq ActiveMQ Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants