Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta: mark api_key config field as required #4127

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 5, 2022

What does this PR do?

This fixes the configuration requirements for the okta api_key.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added the bug Something isn't working, use only for issues label Sep 5, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-12T08:51:31.673+0000

  • Duration: 21 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 5, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (17/17) 💚
Lines 86.69% (495/571)
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review September 5, 2022 10:19
@efd6 efd6 requested a review from a team as a code owner September 5, 2022 10:19
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:okta Okta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[okta] API Key should be labelled as required.
3 participants