Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_logpush: harmonise line endings to unix #4181

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 12, 2022

What does this PR do?

This is a minor clean-up replacing Windows line endings with unix line endings.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cloudflare Cloudflare labels Sep 12, 2022
@efd6 efd6 self-assigned this Sep 12, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-12T08:48:43.009+0000

  • Duration: 35 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 44
Skipped 0
Total 44

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 marked this pull request as ready for review September 12, 2022 05:28
@efd6 efd6 requested a review from a team as a code owner September 12, 2022 05:28
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Sep 12, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 100.0% (89/89) 💚
Lines 94.37% (2380/2522)
Conditionals 100.0% (0/0) 💚

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I guess this repo could use a .gitattributes file and possibly an .editorconfig to help keep establish consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cloudflare Cloudflare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants