Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[influxdb] Initial commit #4190

Merged
merged 30 commits into from
Sep 22, 2022
Merged

[influxdb] Initial commit #4190

merged 30 commits into from
Sep 22, 2022

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Sep 12, 2022 •
edited
Loading

Integration release checklist

This checklist is intended for integrations maintainers to ensure consistency
when creating or updating a Package, Module or Dataset for an Integration.

All changes

  • Change follows the contributing guidelines
  • Supported versions of the monitoring target are documented
  • Supported operating systems are documented (if applicable)
  • Integration or System tests exist
  • Documentation exists
  • Fields follow ECS and naming conventions
  • At least a manual test with ES / Kibana / Agent has been performed.
  • Required Kibana version set to:

@agithomas agithomas mentioned this pull request Sep 12, 2022
Closed
8 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 12, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-22T07:02:40.809+0000

  • Duration: 17 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 12, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.925
Classes 100.0% (0/0) 💚 2.925
Methods 75.0% (6/8) 👎 -14.719
Lines 100.0% (0/0) 💚 8.78
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh changed the title Initial commit [influxdb] Initial commit Sep 12, 2022
@andrewkroh andrewkroh added Integration:influxdb InfluxDb Team:Service-Integrations Label for the Service Integrations team labels Sep 12, 2022
@agithomas agithomas marked this pull request as ready for review September 14, 2022 03:46
ishleenk17
ishleenk17 reviewed Sep 14, 2022
View reviewed changes
packages/influxdb/_dev/deploy/docker/config.yml
http-idle-timeout: 3m0s
http-read-header-timeout: 10s
http-read-timeout: 0s
http-write-timeout: 0s
Copy link
Contributor

@ishleenk17 ishleenk17 Sep 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a lot of config parameters we are giving while running through docker.
Any of these inputs are required from user while collecting metrics ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, these are needed to bring up the minimum running config of the influxdb. It is not related to establishing connection with influxdb

packages/influxdb/data_stream/advstatus/agent/stream/stream.yml.hbs Outdated Show resolved Hide resolved
packages/influxdb/data_stream/status/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
@ishleenk17 ishleenk17 requested a review from a team September 14, 2022 10:14
@agithomas
Copy link
Contributor Author

/test

@muthu-mps
Copy link
Contributor

Just a suggestion here, Do you consider using influxDB logo instead of influxData company logo ?

@v1v
Copy link
Member

v1v commented Sep 20, 2022

/test

ishleenk17
ishleenk17 reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one open comment, changes look fine.

@muthu-mps
Copy link
Contributor

  1. Do you consider changing the names in the dashboard and visualisation's to influxDB.
  2. The dashboard represents 1st, 5th percentile values. I would recommend using 50th, 95th and 97th percentile. Users may be actively looking for these metrics.

@agithomas
Copy link
Contributor Author

  1. Do you consider changing the names in the dashboard and visualisation's to influxDB.
  2. The dashboard represents 1st, 5th percentile values. I would recommend using 50th, 95th and 97th percentile. Users may be actively looking for these metrics.

image

@agithomas agithomas self-assigned this Sep 22, 2022
ishleenk17
ishleenk17 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks for addressing the comments.

@agithomas agithomas merged commit edfac53 into elastic:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthu-mps muthu-mps muthu-mps left review comments

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees

@agithomas agithomas

Labels
Integration:influxdb InfluxDb New Integration Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agithomas @elasticmachine @muthu-mps @v1v @ishleenk17 @andrewkroh