Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_{asa,ftd}: fix handling of 302020 messages #4209

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 14, 2022

What does this PR do?

This fixes the handling of message type 302020 which was being incorrectly characterised as a termination event rather than a start event.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_ftd Cisco FTD Integration:cisco_asa Cisco ASA labels Sep 14, 2022
@efd6 efd6 self-assigned this Sep 14, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T12:12:54.892+0000

  • Duration: 19 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 49
Skipped 0
Total 49

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.679
Classes 100.0% (2/2) 💚 2.679
Methods 100.0% (35/35) 💚 10.241
Lines 76.28% (2666/3495) 👎 -15.161
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review September 14, 2022 04:29
@efd6 efd6 requested a review from a team as a code owner September 14, 2022 04:29
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"event.action": "flow-creation" looks OK in the test results

LGTM

@elasticmachine
Copy link

🚀 Benchmarks report

Package cisco_asa 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 268.82 168.32 -100.5 (-59.71%) 💔

Package cisco_ftd 👍(1) 💚(0) 💔(0)

To see the full report comment with /test benchmark fullreport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants