-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Move dashboard visualizations to by value #4214
Conversation
Changelog missing, will update once this is ready to be merged |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides changelog, I think we are missing the kibana version change in manifest.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the dashboards briefly (all appear to be OK, but I have only checked that audit, firewall and vpc flow render events correctly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as probably moving to lens will be a part of a different PR 👌🏼
Added changelog and remove compatibility with kibana 7.x, as suggested. |
🚀 Benchmarks reportTo see the full report comment with |
As suggested in #4214
Thanks all! |
What does this PR do?
As per #3448 (and it's GCP dedicated issue #3719) we want to migrate Dashboards to use by value visualization instead of by reference.
This PR does it for GCP dashboard available in GCP package as of today.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots