Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Move dashboard visualizations to by value #4214

Merged
merged 7 commits into from
Oct 6, 2022
Merged

[GCP] Move dashboard visualizations to by value #4214

merged 7 commits into from
Oct 6, 2022

Conversation

endorama
Copy link
Member

@endorama endorama commented Sep 14, 2022

What does this PR do?

As per #3448 (and it's GCP dedicated issue #3719) we want to migrate Dashboards to use by value visualization instead of by reference.

This PR does it for GCP dashboard available in GCP package as of today.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@endorama endorama requested review from a team as code owners September 14, 2022 10:00
@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Sep 14, 2022
@endorama endorama self-assigned this Sep 14, 2022
@endorama
Copy link
Member Author

Changelog missing, will update once this is ready to be merged

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-06T13:46:36.623+0000

  • Duration: 20 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 52
Skipped 0
Total 52

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.513
Classes 100.0% (5/5) 💚 2.513
Methods 90.099% (91/101) 👎 -0.208
Lines 95.752% (1375/1436) 👍 4.113
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides changelog, I think we are missing the kibana version change in manifest.yml

Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked all the dashboards yet, but would it be possible to convert the legacy visualizations to Lens when it's possible? For example, for [Logs GCP] Audit dashboard all the selected visualizations are using Visualize and they could be already using Lens.

Screenshot 2022-09-22 at 22 33 51

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the dashboards briefly (all appear to be OK, but I have only checked that audit, firewall and vpc flow render events correctly).

Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as probably moving to lens will be a part of a different PR 👌🏼

@endorama
Copy link
Member Author

Added changelog and remove compatibility with kibana 7.x, as suggested.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

As suggested in #4214
@endorama endorama merged commit 5f5ede9 into elastic:main Oct 6, 2022
@endorama endorama deleted the gcp-dashboard-by-value branch October 6, 2022 15:04
@endorama
Copy link
Member Author

endorama commented Oct 6, 2022

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCP] Migrate package dashboards to by value visualization
5 participants