Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kibana logo #4298

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Update kibana logo #4298

merged 3 commits into from
Sep 26, 2022

Conversation

matschaffer
Copy link
Contributor

@matschaffer matschaffer commented Sep 26, 2022 •
edited
Loading

What does this PR do?

Replaces the kibana package logo with the one from https://brand.elastic.co/302f66895/p/41ff52-solution-logos/b/14d954/i/11013297

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

It's a little complicated. See #4175 for instructions.

Related issues

Closes #4297

Screenshots

Screen Shot 2022-09-26 at 13 24 21

@matschaffer matschaffer added bug Something isn't working, use only for issues Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Sep 26, 2022
@matschaffer matschaffer self-assigned this Sep 26, 2022
@matschaffer matschaffer requested a review from a team as a code owner September 26, 2022 04:24
@elasticmachine
Copy link

elasticmachine commented Sep 26, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-26T04:39:13.118+0000

  • Duration: 13 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.5
Classes 100.0% (0/0) 💚 2.5
Methods 53.846% (14/26) 👎 -36.569
Lines 100.0% (0/0) 💚 9.682
Conditionals 100.0% (0/0) 💚

@miltonhultgren
Copy link
Contributor

Fly be comment: Isn't the ES package's logo also kinda weird?

crespocarlos
crespocarlos approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
image

@crespocarlos
Copy link
Contributor

Fly be comment: Isn't the ES package's logo also kinda weird?

It was using an old logo, but It's been updated here: #4255.

@matschaffer matschaffer merged commit debb239 into elastic:main Sep 26, 2022
@matschaffer matschaffer deleted the fix-kibana-logo branch September 26, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees

@matschaffer matschaffer

Labels
bug Something isn't working, use only for issues Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Fix kibana package logo
4 participants
@matschaffer @elasticmachine @miltonhultgren @crespocarlos