-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add processors setting for k8s data_streams #4363
Add processors setting for k8s data_streams #4363
Conversation
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@@ -38,3 +38,6 @@ processors: | |||
throw "expected kubernetes.audit.annotations.authorization_k8s_io/decision === allow"; | |||
} | |||
} | |||
{{#if processors}} | |||
{{processors}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider put the text label processors:
see https://github.com/elastic/integrations/pull/4363/files#diff-ac6d0299b88d719f78da294ca253c144259234b3e89c0a48e5f6b7e00127eaa8R21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we don't need it because we just append the "processors" under the already existent list. See https://github.com/elastic/integrations/pull/4363/files/269562fce8a3910e54eac402cc7e60782c2cccaa#diff-ede93cff25650ee8746c4bd4dff62a34caf8bff51d82219bb6792a59b9111c50R10
🌐 Coverage report
|
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Unfortunately we cannot have a commented default placeholder (b587fff) because this makes the tests (and in general Agent) to fail. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark was this version of the package promoted? |
|
What does this PR do?
Adds
processors
fields for all the Kubernetes data_streams.Checklist
changelog.yml
file.Related issues
processor
optional input for the Kubernetes integration #4288Screenshots
TBA