Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processors setting for k8s data_streams #4363

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Oct 3, 2022

What does this PR do?

Adds processors fields for all the Kubernetes data_streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

TBA

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark self-assigned this Oct 3, 2022
@ChrsMark ChrsMark requested a review from a team as a code owner October 3, 2022 10:21
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@@ -38,3 +38,6 @@ processors:
throw "expected kubernetes.audit.annotations.authorization_k8s_io/decision === allow";
}
}
{{#if processors}}
{{processors}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elasticmachine
Copy link

elasticmachine commented Oct 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-03T12:06:34.073+0000

  • Duration: 33 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 90
Skipped 0
Total 90

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 3, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.564
Classes 100.0% (0/0) 💚 2.564
Methods 94.872% (74/78) 👍 4.818
Lines 100.0% (0/0) 💚 8.471
Conditionals 100.0% (0/0) 💚

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 3, 2022

Unfortunately we cannot have a commented default placeholder (b587fff) because this makes the tests (and in general Agent) to fail.
I get {"log.level":"error","@timestamp":"2022-10-03T11:45:46.802Z","log.origin":{"file.name":"fleet/fleet_gateway.go","file.line":204},"message":"failed to dispatch actions, error: fail to generate program configuration: failed to add stream processor to configuration: InjectStreamProcessorRule: processors is not a list","ecs.version":"1.6.0"} in the tests. I guess we cannot have a commented-out section as value for the processors key. I will remove the default placeholder.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@tetianakravchenko
Copy link
Contributor

@ChrsMark was this version of the package promoted?

@ChrsMark
Copy link
Member Author

ChrsMark commented Nov 2, 2022

@ChrsMark was this version of the package promoted?

elastic/package-storage#5965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add processor optional input for the Kubernetes integration
5 participants