Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netflow] Fix invalid Kibana search indexRefName reference #4379

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Oct 4, 2022

What does this PR do?

Fixes an invalid reference in a Kibana search saved object.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • elastic/sdh-beats#2572

@taylor-swanson taylor-swanson added bug Something isn't working, use only for issues Integration:netflow NetFlow Records labels Oct 4, 2022
@taylor-swanson taylor-swanson self-assigned this Oct 4, 2022
@elasticmachine
Copy link

🚀 Benchmarks report

Package netflow 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 26315.79 14492.75 -11823.04 (-44.93%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-04T20:41:54.275+0000

  • Duration: 15 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 91
Skipped 0
Total 91

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.573
Classes 100.0% (1/1) 💚 2.573
Methods 100.0% (7/7) 💚 9.819
Lines 100.0% (56/56) 💚 8.418
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review October 4, 2022 21:04
@taylor-swanson taylor-swanson requested a review from a team as a code owner October 4, 2022 21:04
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; confirmed locally.

@taylor-swanson taylor-swanson merged commit 7d69576 into elastic:main Oct 5, 2022
@taylor-swanson taylor-swanson deleted the netflow-search-fix branch October 5, 2022 13:04
@andrewkroh andrewkroh changed the title Fix invalid Kibana search indexRefName reference [netflow] Fix invalid Kibana search indexRefName reference Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:netflow NetFlow Records
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants