-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "security" category to featured security integrations #4392
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But if you want these changes to ship then you need to bump the version and add a changelog entry to each package. This tool can do the work for you https://github.com/elastic/elastic-package#elastic-package-changelog.
Hi @andrewkroh thanks for this! Does it seem like overkill to bump the package versions for a category addition? I guess cloud security may be under active dev so a new version will be released soon-ish, network traffic may not have a new release coming out soon so I may do it for that one? |
Yeah, you can bump it. I would just roll the patch version. e.g.
|
a7f051d
to
a717abe
Compare
Thanks so much for your help Andrew. @oren-zohar I have re-requested your review, would you be happy for me to bump the cloud_securoty_posture version to get this change released? |
yes if you could it would be great, thanks Mark 🙏 |
What does this PR do?
As part of elastic/kibana#141823, we want to have featured integrations for certain categories. The network_traffic and cloud_security_posture integrations will be featured in the security category so they need the security category in the manifest.