Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "security" category to featured security integrations #4392

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Oct 5, 2022

What does this PR do?

As part of elastic/kibana#141823, we want to have featured integrations for certain categories. The network_traffic and cloud_security_posture integrations will be featured in the security category so they need the security category in the manifest.

@hop-dev hop-dev added the enhancement New feature or request label Oct 5, 2022
@hop-dev hop-dev self-assigned this Oct 5, 2022
@hop-dev hop-dev requested review from a team as code owners October 5, 2022 14:33
@hop-dev hop-dev changed the title add security category to featured security integrations Add "security" category to featured security integrations Oct 5, 2022
@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-10T13:06:03.217+0000

  • Duration: 80 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 266
Skipped 0
Total 266

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.547
Classes 100.0% (0/0) 💚 2.547
Methods 69.118% (47/68) 👎 -21.096
Lines 100.0% (0/0) 💚 8.461
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But if you want these changes to ship then you need to bump the version and add a changelog entry to each package. This tool can do the work for you https://github.com/elastic/elastic-package#elastic-package-changelog.

@hop-dev
Copy link
Contributor Author

hop-dev commented Oct 6, 2022

LGTM. But if you want these changes to ship then you need to bump the version and add a changelog entry to each package. This tool can do the work for you https://github.com/elastic/elastic-package#elastic-package-changelog.

Hi @andrewkroh thanks for this! Does it seem like overkill to bump the package versions for a category addition? I guess cloud security may be under active dev so a new version will be released soon-ish, network traffic may not have a new release coming out soon so I may do it for that one?

@andrewkroh
Copy link
Member

network traffic may not have a new release coming out soon so I may do it for that one?

Yeah, you can bump it. I would just roll the patch version. e.g.

elastic-package changelog add --description "Add security category to package metadata." --link https://github.com/elastic/integrations/pull/4392 --type enhancement --next patch

@hop-dev hop-dev force-pushed the kibana-141823-add-security-category branch from a7f051d to a717abe Compare October 10, 2022 13:05
@hop-dev
Copy link
Contributor Author

hop-dev commented Oct 10, 2022

Thanks so much for your help Andrew.

@oren-zohar I have re-requested your review, would you be happy for me to bump the cloud_securoty_posture version to get this change released?

@hop-dev hop-dev merged commit b70ed8a into main Oct 10, 2022
@hop-dev hop-dev deleted the kibana-141823-add-security-category branch October 10, 2022 15:09
@oren-zohar
Copy link
Contributor

oren-zohar commented Oct 10, 2022

Thanks so much for your help Andrew.

@oren-zohar I have re-requested your review, would you be happy for me to bump the cloud_securoty_posture version to get this change released?

yes if you could it would be great, thanks Mark 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants