Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microsoft_dhcp] Fix broken hyperlink in docs #4393

Merged
merged 5 commits into from
Oct 6, 2022
Merged

[microsoft_dhcp] Fix broken hyperlink in docs #4393

merged 5 commits into from
Oct 6, 2022

Conversation

nicpenning
Copy link
Contributor

  • Bug

What does this PR do?

This fixes an issue in the documentation and does not impact the integration itself.

The hyperlink is broken and displays incorrectly here on GitHub and in Kibana. Also, the last parenthesis ")" is not properly parsed either so the link doesn't work at all in Kibana, (you will get a 404 not found).

Screenshots

image

image

The hyperlink is broken and displays incorrectly here on GitHub and in Kibana. Also, the last parenthesis ")" is not properly parsed either so the link doesn't work at all in Kibana, (you will get a 404 not found).
@nicpenning nicpenning requested a review from a team as a code owner October 5, 2022 17:47
@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-06T06:27:36.689+0000

  • Duration: 13 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@nicpenning nicpenning changed the title [microsoft_dhcp] - Fix broken hyperlink in docs [microsoft_dhcp] Fix broken hyperlink in docs Oct 5, 2022
@efd6
Copy link
Contributor

efd6 commented Oct 6, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Oct 6, 2022

/test

@elasticmachine
Copy link

🚀 Benchmarks report

Package microsoft_dhcp 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 50000 23809.52 -26190.48 (-52.38%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 2.73
Classes 100.0% (3/3) 💚 2.73
Methods 100.0% (21/21) 💚 10.067
Lines 99.205% (624/629) 👍 7.559
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants