-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microsoft_dhcp] Fix broken hyperlink in docs #4393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hyperlink is broken and displays incorrectly here on GitHub and in Kibana. Also, the last parenthesis ")" is not properly parsed either so the link doesn't work at all in Kibana, (you will get a 404 not found).
efd6
reviewed
Oct 5, 2022
nicpenning
changed the title
[microsoft_dhcp] - Fix broken hyperlink in docs
[microsoft_dhcp] Fix broken hyperlink in docs
Oct 5, 2022
/test |
efd6
reviewed
Oct 6, 2022
/test |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
log |
50000 | 23809.52 | -26190.48 (-52.38%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
efd6
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes an issue in the documentation and does not impact the integration itself.
The hyperlink is broken and displays incorrectly here on GitHub and in Kibana. Also, the last parenthesis ")" is not properly parsed either so the link doesn't work at all in Kibana, (you will get a 404 not found).
Screenshots