Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akamai,auditd,barracuda,bluecoat,box_events,carbon_black_cloud,cef: remove duplicated fields #4399

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 6, 2022

What does this PR do?

This removes duplicated field definitions in a some of the SEI packages identified in #4398.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cef Common Event Format (CEF) Integration:barracuda_cloudgen_firewall Barracuda CloudGen Firewall Logs Integration:bluecoat Blue Coat Director Logs (Deprecated) Integration:auditd Auditd Logs Integration:carbon_black_cloud VMware Carbon Black Cloud Integration:akamai Akamai Integration:box_events Box Events labels Oct 6, 2022
@efd6 efd6 self-assigned this Oct 6, 2022
@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

🚀 Benchmarks report

Package akamai 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
siem 2433.09 1721.17 -711.92 (-29.26%) 💔

Package barracuda 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
spamfirewall 41666.67 32258.06 -9408.61 (-22.58%) 💔

Package bluecoat 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
director 38461.54 27777.78 -10683.76 (-27.78%) 💔

Package cef 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 2475.25 2016.13 -459.12 (-18.55%) 💔

Package lastpass 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
detailed_shared_folder 13513.51 7092.2 -6421.31 (-47.52%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T07:25:37.670+0000

  • Duration: 19 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 331
Skipped 0
Total 331

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (19/19) 💚
Files 100.0% (21/21) 💚 2.496
Classes 100.0% (21/21) 💚 2.496
Methods 94.239% (229/243) 👍 3.905
Lines 94.917% (6312/6650) 👍 3.287
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review October 6, 2022 05:02
@efd6 efd6 requested a review from a team as a code owner October 6, 2022 05:02
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor Author

efd6 commented Oct 6, 2022

/test

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Auditd.logs
    • Missing deletion on these fields: container.name, host.architecture, user.effective.group.id, user.effective.group.name, user.effective.id, user.effective.name
  • cabon_black_cloud.asset_vulnerability_summary
    • host.ip is not duplicated, but being removed in the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:akamai Akamai Integration:auditd Auditd Logs Integration:barracuda_cloudgen_firewall Barracuda CloudGen Firewall Logs Integration:bluecoat Blue Coat Director Logs (Deprecated) Integration:box_events Box Events Integration:carbon_black_cloud VMware Carbon Black Cloud Integration:cef Common Event Format (CEF)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants