-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
akamai,auditd,barracuda,bluecoat,box_events,carbon_black_cloud,cef: remove duplicated fields #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Something isn't working, use only for issues
Team:Security-External Integrations
Integration:cef
Common Event Format (CEF)
Integration:barracuda_cloudgen_firewall
Barracuda CloudGen Firewall Logs
Integration:bluecoat
Blue Coat Director Logs (Deprecated)
Integration:auditd
Auditd Logs
Integration:carbon_black_cloud
VMware Carbon Black Cloud
Integration:akamai
Akamai
Integration:box_events
Box Events
labels
Oct 6, 2022
60 tasks
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
siem |
2433.09 | 1721.17 | -711.92 (-29.26%) | 💔 |
Package barracuda
👍(1) 💚(0) 💔(1)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
spamfirewall |
41666.67 | 32258.06 | -9408.61 (-22.58%) | 💔 |
Package bluecoat
👍(0) 💚(0) 💔(1)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
director |
38461.54 | 27777.78 | -10683.76 (-27.78%) | 💔 |
Package cef
👍(0) 💚(0) 💔(1)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
log |
2475.25 | 2016.13 | -459.12 (-18.55%) | 💔 |
Package lastpass
👍(2) 💚(0) 💔(1)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
detailed_shared_folder |
13513.51 | 7092.2 | -6421.31 (-47.52%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
/test |
…emove duplicated fields
kcreddy
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Auditd.logs
- Missing deletion on these fields:
container.name, host.architecture, user.effective.group.id, user.effective.group.name, user.effective.id, user.effective.name
- Missing deletion on these fields:
- cabon_black_cloud.asset_vulnerability_summary
host.ip
is not duplicated, but being removed in the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working, use only for issues
Integration:akamai
Akamai
Integration:auditd
Auditd Logs
Integration:barracuda_cloudgen_firewall
Barracuda CloudGen Firewall Logs
Integration:bluecoat
Blue Coat Director Logs (Deprecated)
Integration:box_events
Box Events
Integration:carbon_black_cloud
VMware Carbon Black Cloud
Integration:cef
Common Event Format (CEF)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This removes duplicated field definitions in a some of the SEI packages identified in #4398.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots