Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add santa integration #440

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Add santa integration #440

merged 1 commit into from
Dec 4, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 3, 2020

What does this PR do?

Add Google Santa integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Screenshots

image
image

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Dec 3, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #440 updated

  • Start Time: 2020-12-04T11:31:54.466+0000

  • Duration: 12 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 0
Total 60

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


The Google Santa integration was tested with logs from Santa 0.9.14.

**This module is available for MacOS only.**
Copy link
Contributor

@adriansr adriansr Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what this means, as my understanding is that this module just reads from a file, there's nothing macOS specific about it other than the software that generates this file is macOS-only. I know this message is already in the Filebeat module, so don't mind me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rephrasing to something like: Google Santa is available for MacOS only makes more sense?

@marc-gr marc-gr merged commit bc988c5 into elastic:master Dec 4, 2020
@marc-gr marc-gr deleted the santa branch December 4, 2020 12:30
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants