[infoblox_nios] Handle bad values in IP and Date fields #4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinit-chauhan
added
enhancement
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
1650.17 | 1700.68 | 50.51 (3.06%) | 👍 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
/test benchmark fullreport |
efd6
approved these changes
Oct 24, 2022
| @@ -17,51 +17,75 @@ processors: | |||
| - rename: | |||
| field: _conf.tz_offset | |||
| target_field: event.timezone | |||
| if: "ctx?._conf?.tz_offset != null && ctx._conf.tz_offset != 'local'" | |||
| if: ctx?._conf?.tz_offset != null && ctx._conf.tz_offset != 'local' | |||
There was a problem hiding this comment.
Suggested change
| if: ctx?._conf?.tz_offset != null && ctx._conf.tz_offset != 'local' | |
| if: ctx._conf?.tz_offset != null && ctx._conf.tz_offset != 'local' |
| @@ -1,43 +1,48 @@ | |||
| # newer versions go on top | |||
| - version: "1.3.1" | |||
| - version: '1.3.2' | |||
There was a problem hiding this comment.
Is there a reason for the ~global replace of " with '?
|
I have an SDH waiting on this fix. If there are no other blockers, could we get this merged? I'll merge it tomorrow if no one beats me to it by then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
This PR adds support for handling bad values in IP and Date fields. Below is the table showing the more updates on this PR.
Checklist
changelog.ymlfile.How to test this PR locally
Screenshots
Related issues