Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dashboards to by_value #4516

Merged
merged 111 commits into from
Dec 7, 2022
Merged

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Oct 28, 2022

What does this PR do?

As a best practice, this would move visualisations to by_value instead of by_reference

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Commands used for an integration:

  • elastic-package stack down && elastic-package stack up --version=x.y.z -d -v (x.y.z values taken from kibana.version in the package's manifest.yml)
  • cd legacy_vis_analyzer (cloned from https://github.com/flash1293/legacy_vis_analyzer)
  • KIBANA="https://elastic:changeme@localhost:5601" NODE_TLS_REJECT_UNAUTHORIZED='0' node inline.js ./elastic/integrations/packages/1password/kibana/

Sample output:

Prepared 8 visualizations to be inlined
Prepared 2 maps to be inlined
Processing dashboard Item Usages [1Password]
Leaving panel of type search
Inlined a map, pushed 1 inner references
Inlined a vis, pushed 1 inner references
Inlined a vis, pushed 1 inner references
Inlined a vis, pushed 1 inner references
Inlined a vis, pushed 1 inner references
Processing dashboard Sign-in Attempts [1Password]
Leaving panel of type search
Inlined a map, pushed 1 inner references
Inlined a vis, pushed 1 inner references
Inlined a vis, pushed 1 inner references
Inlined a vis, pushed 1 inner references
Inlined a vis, pushed 1 inner references
Inlined 8 visualizations
Inlined 2 maps
Inlined 0 lenses
Removing visualization folder
Removing maps folder
Writing back dashboards

@elasticmachine
Copy link

Package 1password - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=1password

@elasticmachine
Copy link

Package auditd - 3.4.1 containing this change is available at https://epr.elastic.co/search?package=auditd

@elasticmachine
Copy link

Package auth0 - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=auth0

@elasticmachine
Copy link

Package cef - 2.4.1 containing this change is available at https://epr.elastic.co/search?package=cef

@elasticmachine
Copy link

Package cisco_asa - 2.10.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@elasticmachine
Copy link

Package cloudflare - 2.3.1 containing this change is available at https://epr.elastic.co/search?package=cloudflare

@elasticmachine
Copy link

Package hid_bravura_monitor - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor

@elasticmachine
Copy link

Package iptables - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=iptables

@elasticmachine
Copy link

Package microsoft_defender_endpoint - 2.5.2 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint

@elasticmachine
Copy link

Package mimecast - 1.4.2 containing this change is available at https://epr.elastic.co/search?package=mimecast

@elasticmachine
Copy link

Package netflow - 2.3.2 containing this change is available at https://epr.elastic.co/search?package=netflow

@elasticmachine
Copy link

Package network_traffic - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=network_traffic

@elasticmachine
Copy link

Package o365 - 1.9.2 containing this change is available at https://epr.elastic.co/search?package=o365

@elasticmachine
Copy link

Package okta - 1.11.2 containing this change is available at https://epr.elastic.co/search?package=okta

@elasticmachine
Copy link

Package osquery - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=osquery

@elasticmachine
Copy link

Package pfsense - 1.4.2 containing this change is available at https://epr.elastic.co/search?package=pfsense

@elasticmachine
Copy link

Package qnap_nas - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=qnap_nas

@elasticmachine
Copy link

Package santa - 3.4.1 containing this change is available at https://epr.elastic.co/search?package=santa

@elasticmachine
Copy link

Package suricata - 2.5.3 containing this change is available at https://epr.elastic.co/search?package=suricata

@elasticmachine
Copy link

Package zeek - 2.6.1 containing this change is available at https://epr.elastic.co/search?package=zeek

@elasticmachine
Copy link

Package microsoft_defender_endpoint - 2.6.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[security-external-integrations packages] Migrate dashboards to by_value
4 participants