Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ti_{cif3,recordedfuture}: map threat.indicator.geo.location as geo_point #4552

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 3, 2022

What does this PR do?

This uses the ECS definition of threat.indicator.geo.location to ensure that it is mapped as geo_point.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:ti_util Threat Intelligence Utilities labels Nov 3, 2022
@efd6 efd6 self-assigned this Nov 3, 2022
@efd6 efd6 force-pushed the 4542-ti branch 2 times, most recently from dd38ded to 499731b Compare November 3, 2022 20:39
@elasticmachine
Copy link

elasticmachine commented Nov 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-04T09:53:08.176+0000

  • Duration: 16 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 3, 2022

🚀 Benchmarks report

Package ti_cif3 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
feed 2386.63 1945.53 -441.1 (-18.48%) 💔

Package ti_recordedfuture 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threat 6172.84 4975.12 -1197.72 (-19.4%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 3, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (3/3) 💚 2.504
Classes 100.0% (3/3) 💚 2.504
Methods 93.333% (28/30) 👍 2.492
Lines 62.587% (271/433) 👎 -29.361
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 3, 2022 20:57
@efd6 efd6 requested a review from a team as a code owner November 3, 2022 20:57
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit f77312a into elastic:main Nov 4, 2022
@djptek
Copy link
Contributor

djptek commented Nov 4, 2022

Thanks @efd6

@djptek
Copy link
Contributor

djptek commented Nov 4, 2022

Applied already 👍

image

djptek pushed a commit to djptek-legacy/integrations that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:ti_util Threat Intelligence Utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ti_recordedfuture.threat incorrect field type threat.indicator.geo.location [Recorded Future]
4 participants