-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hid_bravura_monitor,imperva,infoblox_*,zscalar_*: remove duplicate fields #4610
Conversation
🚀 Benchmarks reportTo see the full report comment with |
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 Just minor clarifications and resolving conflicts.
-
zscaler_zia.firewall
: Couldn't findhost.hostname
field in ecs.yml -
Also, just looking for conformity/preference:
In
imperva
these are the duplicates:
"securesphere":@timestamp
base-fields.yml, ecs.yml
"securesphere":tags
base-fields.yml, ecs.ymlPR removes
@timestamp
from base-fields.yml buttags
from ecs.yml. Is there any preference of one over the other?
|
…elds Also make minor bugfixes in two packages. * markdown syntax for proxy_url description in infoblox_bloxone_ddi * normalization of x509.issuer.common_name in zpa
Package hid_bravura_monitor - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor |
Package imperva - 0.11.1 containing this change is available at https://epr.elastic.co/search?package=imperva |
Package infoblox_bloxone_ddi - 0.2.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi |
1 similar comment
Package infoblox_bloxone_ddi - 0.2.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi |
Package infoblox_nios - 1.4.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_nios |
Package zscaler_zia - 2.6.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia |
Package zscaler_zpa - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa |
1 similar comment
Package zscaler_zpa - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa |
Great, thanks!! |
What does this PR do?
This removes duplicate field definitions in hid_bravura_monitor, imperva, infoblox_bloxoneddi, infoblox_nios ,zscalar_zia and zscalar_zpa.
It also makes minor bugfixes in two packages.
proxy_url
description in infoblox_bloxone_ddix509.issuer.common_name
in zpaChecklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots