Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hid_bravura_monitor,imperva,infoblox_*,zscalar_*: remove duplicate fields #4610

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 9, 2022

What does this PR do?

This removes duplicate field definitions in hid_bravura_monitor, imperva, infoblox_bloxoneddi, infoblox_nios ,zscalar_zia and zscalar_zpa.

It also makes minor bugfixes in two packages.

  • markdown syntax for proxy_url description in infoblox_bloxone_ddi
  • normalization of x509.issuer.common_name in zpa

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Nov 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-29T06:33:06.877+0000

  • Duration: 22 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 261
Skipped 0
Total 261

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 self-assigned this Nov 9, 2022
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:infoblox_nios Infoblox NIOS Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI Integration:imperva Imperva Integration:zscaler_zpa Zscaler Private Access Integration:zscaler_zia Zscaler Internet Access labels Nov 9, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 9, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 9, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 100.0% (20/20) 💚 3.828
Classes 100.0% (20/20) 💚 3.828
Methods 98.319% (234/238) 👍 11.998
Lines 94.429% (6729/7126) 👍 0.341
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 9, 2022 23:22
@efd6 efd6 requested a review from a team as a code owner November 9, 2022 23:22
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Just minor clarifications and resolving conflicts.

  1. zscaler_zia.firewall: Couldn't find host.hostname field in ecs.yml

  2. Also, just looking for conformity/preference:

    In imperva these are the duplicates:
    "securesphere": @timestamp base-fields.yml, ecs.yml
    "securesphere": tags base-fields.yml, ecs.yml

    PR removes @timestamp from base-fields.yml but tags from ecs.yml. Is there any preference of one over the other?

@efd6
Copy link
Contributor Author

efd6 commented Nov 29, 2022

  1. Yep, it looks like this was removed in 864f94c#diff-1e300be11bf240a33db1347d839996c0a73a33202d0525a8a7b6d67038ee561b. Given this, I don't know how safe this change is. I'll rebase onto main and recheck after fixing the conflicts.
  2. I don't have a real preference. I would love it if there were only one file. I guess my preference is the option that has the lowest amount of text remaining, but what I have done over the full set is not necessarily consistent.

…elds

Also make minor bugfixes in two packages.

* markdown syntax for proxy_url description in infoblox_bloxone_ddi
* normalization of x509.issuer.common_name in zpa
@efd6 efd6 merged commit e025b56 into elastic:main Nov 29, 2022
@elasticmachine
Copy link

Package hid_bravura_monitor - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor

@elasticmachine
Copy link

Package imperva - 0.11.1 containing this change is available at https://epr.elastic.co/search?package=imperva

@elasticmachine
Copy link

Package infoblox_bloxone_ddi - 0.2.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

1 similar comment
@elasticmachine
Copy link

Package infoblox_bloxone_ddi - 0.2.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

@elasticmachine
Copy link

Package infoblox_nios - 1.4.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_nios

@elasticmachine
Copy link

Package zscaler_zia - 2.6.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia

@elasticmachine
Copy link

Package zscaler_zpa - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

1 similar comment
@elasticmachine
Copy link

Package zscaler_zpa - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

@kcreddy
Copy link
Contributor

kcreddy commented Nov 30, 2022

  1. Yep, it looks like this was removed in 864f94c#diff-1e300be11bf240a33db1347d839996c0a73a33202d0525a8a7b6d67038ee561b. Given this, I don't know how safe this change is. I'll rebase onto main and recheck after fixing the conflicts.
  2. I don't have a real preference. I would love it if there were only one file. I guess my preference is the option that has the lowest amount of text remaining, but what I have done over the full set is not necessarily consistent.

Great, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:hid_bravura_monitor Bravura Monitor Integration:imperva Imperva Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI Integration:infoblox_nios Infoblox NIOS Integration:zscaler_zia Zscaler Internet Access Integration:zscaler_zpa Zscaler Private Access
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants