[Enhancement] [Carbon Black Cloud] Make enhancement in connector with best practices implementation #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to the convert and date processors and update the pagination termination condition
vinit-chauhan
added
enhancement
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
efd6
reviewed
Nov 15, 2022
| @@ -83,23 +122,17 @@ processors: | |||
| - grok: | |||
| field: host.hostname | |||
| patterns: | |||
| - '^(%{DATA:user.domain})\\(%{GREEDYDATA:host.hostname})$' | |||
| - "^(%{DATA:user.domain})\\\\(%{GREEDYDATA:host.hostname})$" | |||
There was a problem hiding this comment.
This change doesn't seem like a win.
| @@ -2,16 +2,14 @@ | |||
| title: Cloud | |||
| group: 2 | |||
| description: Fields related to the cloud or infrastructure the events are coming from. | |||
| footnote: 'Examples: If Metricbeat is running on an EC2 host and fetches data from its host, the cloud info contains the data about this machine. If Metricbeat runs on a remote machine outside the cloud and fetches data from a service running in the cloud, the field contains cloud data from the machine the service is running on.' | |||
| footnote: "Examples: If Metricbeat is running on an EC2 host and fetches data from its host, the cloud info contains the data about this machine. If Metricbeat runs on a remote machine outside the cloud and fetches data from a service running in the cloud, the field contains cloud data from the machine the service is running on." | |||
There was a problem hiding this comment.
What is the rationale for the change here and below?
...ges/carbon_black_cloud/data_stream/endpoint_event/_dev/test/pipeline/test-endpoint-event.log
Show resolved
Hide resolved
P1llus
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
Make enhancement in Carbon Black Cloud connector with listed best practices.
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Screenshots