Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] [Proofpoint TAP] Update the Pagination Termination Condition #4699

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

vinit-chauhan
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

Update the Pagination Termination Condition for Proofpoint TAP connector.

Current condition for pagination termination contains [[else]][[.last_response.terminate_pagination]][[end]] which results in error logs when pagination is completed.

Removing this else condition will not result in error logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/proofpoint_tap directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image
image

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner November 23, 2022 07:36
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

1 similar comment
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-23T07:36:40.722+0000

  • Duration: 18 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (62/62) 💚
Lines 98.415% (1242/1262)
Conditionals 100.0% (0/0) 💚

@P1llus P1llus merged commit ed53f07 into elastic:main Nov 25, 2022
@elasticmachine
Copy link

Package proofpoint_tap - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=proofpoint_tap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:proofpoint_tap Proofpoint TAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants